-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
John conroy/publication related data #3046
Merged
john-conroy
merged 25 commits into
john-conroy/publication-summary
from
john-conroy/publication-related-data
Mar 21, 2023
Merged
John conroy/publication related data #3046
john-conroy
merged 25 commits into
john-conroy/publication-summary
from
john-conroy/publication-related-data
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
added a commit
that referenced
this pull request
Mar 21, 2023
* Move summary title to own component * Add util to get combined dataset status * Add basic publication page summary * Pull repeated array into variable * Replace hubmap id with title prop in summary * Add title for publication summary * John conroy/publication related data (#3046) * Make derived entities tabs more flexible to entities * Change derived entities section header for reuse with publications data * Make derived entities tabs accept warning message fn as prop * Pass aria label as props to tabs * Rename derived entities tabs to related entities tabs * Rename derived entities section wrapper * Add related entities table component * Add shared columns file * Add entity type to derived entity hooks * Update entities table to take header and body rows as props * Use related entities table in derived table components * Fix import * Add hook to fetch ancestors * Add publication entities tabs * Pass columns to tabs * Add donors and define columns for publication entities * Consolidate hooks * Consolidate derived entities hooks * Move hooks from page inside derived datasets * Update prop name * Update entities table story * Use tabs in derived datasets section and remove unused table components * Move hooks for derived inside component * Fix formatting issues * Add changelog --------- Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: John Conroy <[email protected]>
john-conroy
added a commit
that referenced
this pull request
Mar 21, 2023
* Add browse route for publication * Add changelog * John conroy/publication summary (#3045) * Move summary title to own component * Add util to get combined dataset status * Add basic publication page summary * Pull repeated array into variable * Replace hubmap id with title prop in summary * Add title for publication summary * John conroy/publication related data (#3046) * Make derived entities tabs more flexible to entities * Change derived entities section header for reuse with publications data * Make derived entities tabs accept warning message fn as prop * Pass aria label as props to tabs * Rename derived entities tabs to related entities tabs * Rename derived entities section wrapper * Add related entities table component * Add shared columns file * Add entity type to derived entity hooks * Update entities table to take header and body rows as props * Use related entities table in derived table components * Fix import * Add hook to fetch ancestors * Add publication entities tabs * Pass columns to tabs * Add donors and define columns for publication entities * Consolidate hooks * Consolidate derived entities hooks * Move hooks from page inside derived datasets * Update prop name * Update entities table story * Use tabs in derived datasets section and remove unused table components * Move hooks for derived inside component * Fix formatting issues * Add changelog --------- Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> * Update changelog --------- Co-authored-by: John Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3035. Refactor existing derived entity components for reuse and consolidate appearances.