-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aloha real-world datasets #175
Merged
Cadene
merged 31 commits into
main
from
user/rcadene/2024_05_11_fix_aloha_static_mobile_datasets
May 20, 2024
Merged
Fix aloha real-world datasets #175
Cadene
merged 31 commits into
main
from
user/rcadene/2024_05_11_fix_aloha_static_mobile_datasets
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f896667
to
1d9433b
Compare
alexander-soare
suggested changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤗
…11_fix_aloha_static_mobile_datasets
…sors: convert to Git LFS
…tensors: convert to Git LFS
…etensors: convert to Git LFS
…etensors: convert to Git LFS
… convert to Git LFS
…rs: convert to Git LFS
…ors: convert to Git LFS
…ors: convert to Git LFS
Cadene
commented
May 19, 2024
AdilZouitine
approved these changes
May 20, 2024
alexander-soare
suggested changes
May 20, 2024
alexander-soare
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
HalvardBariller
pushed a commit
to HalvardBariller/lerobot
that referenced
this pull request
May 21, 2024
menhguin
pushed a commit
to menhguin/lerobot
that referenced
this pull request
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review filters
What this does
Core:
gdown
, so I uploaded all raw dataset to the hub, to then being able to download them from the hub and getting rid ofgdown
.Addition:
export HF_HUB_ENABLE_HF_TRANSFER=1
episode_index
issue affecting all the aloha datasets. As a result:episode_index=0
is not the same anymoreepisode_index=0
velocity
andeffort
to all aloha (real-world) datasets @haixuanTaoHow it was tested
Manually checked all episodes are inside raw dataset stored on the hub in: https://huggingface.co/cadene
Downloaded all datasets and visualized the first episode of each (I had to code a faster visualization than rerun: Add visualize_dataset_html with
http.server
#188)Double-checked backward compatibility with previous datasets
Visualized random episodes of all datasets
https://github.com/huggingface/lerobot/assets/4681518/07f71279-2d8c-409d-8f71-a3f8c1c29fb5
Checked that the order of episodes had changed as expected for aloha sim datasets.
How to checkout & try?
dgx
):user/rcadene/2024_05_11_fix_aloha_static_mobile_datasets
): Add visualize_dataset_html withhttp.server
#188