update find_available_ports to use serial.tools.list_ports #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetsitaram
force-pushed
the
list-ports
branch
from
da5a5a7 to
1b90939
Compare
|
@meetsitaram Thanks a lot for your PR, and for testing it on Mac, Linux and Windows. We will work on merging it as soon as we added Continuous Integration on these 3 environments. As of now we run CI on Linux only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Update
dynamizel.py::find_available_portsto detect usb port connected to the dynamixel servos in multiple platforms - windows, mac and linux. The current approach of usingPath("/dev").glob("tty*")was unable to detect ports in windows.How it was tested
I tested the logic by running on a pc, mac as well as a linux virtual machine and was able to detect the port on all three platforms.
COM5/dev/cu.usbmodel585A00081751/dev/ttyACM0How to checkout & try? (for the reviewer)
This can be tested only when running the dynamixel script while connecting and disconnected the usb device.