Fix safe_action #395
Merged
Fix safe_action #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@alexander-soare @Cadene should we set a default value for |
alexander-soare
approved these changes
Aug 30, 2024
amandip7
pushed a commit
to amandip7/lerobot
that referenced
this pull request
Oct 10, 2024
menhguin
pushed a commit
to menhguin/lerobot
that referenced
this pull request
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Fixes
KochRobot.send_actionwhenmax_relative_targetis not set (None)How it was tested
@alexander-soare tested this logic on his robot in #396 (duplicate)
How to checkout & try? (for the reviewer)
N/A