[2.x] Normalize codeblock styles and remove Torchlight enabled class #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the color of Tailwind Typography (Prose) styles on Markdown codeblocks from pure black to #292D3E to match the same color Torchlight uses for consistency.
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-hydefront-styles-to-tailwind #2036 +/- ##
=========================================================================
Coverage 100.00% 100.00%
Complexity 1906 1906
=========================================================================
Files 195 195
Lines 5078 5080 +2
=========================================================================
+ Hits 5078 5080 +2 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
normalize-code-block-styles-and-remove-has-torchlight-class
branch
2 times, most recently
from
cb628ab to
0fd187f
Compare
caendesilva
force-pushed
the
normalize-code-block-styles-and-remove-has-torchlight-class
branch
from
0fd187f to
71b5b71
Compare
caendesilva
changed the title
caendesilva
merged commit 250b3e1
into
refactor-hydefront-styles-to-tailwind
8 checks passed
caendesilva
deleted the
normalize-code-block-styles-and-remove-has-torchlight-class
branch
This was referenced Nov 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This pull request normalizes the unstyled Tailwind Prose code blocks to match the Torchlight styling, also removing the need for the
.torchlight-enabledCSS class. Also refactors the filepath label component to use Tailwind styles in the existing Blade component instead of the HydeFron SCSS. Part of #2024Before
After