[2.x] Remove the hyde.css file from HydeFront
#2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script verified to still work
caendesilva
added
the
run-visual-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-hydefront-styles-to-tailwind #2037 +/- ##
=========================================================================
Coverage 100.00% 100.00%
Complexity 1906 1906
=========================================================================
Files 195 195
Lines 5080 5080
=========================================================================
Hits 5080 5080 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
remove-the-hyde-css-file-from-hydefront
branch
from
f1cf6dd to
2034b01
Compare
This was referenced Nov 17, 2024
Merged
caendesilva
merged commit 3c42843
into
refactor-hydefront-styles-to-tailwind
8 checks passed
github-actions
bot
removed
the
run-visual-tests
caendesilva
changed the title
hyde.css file from HydeFronthyde.css file from HydeFront
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
hyde.cssfile from HydeFront as all its styles has now been refactored to Tailwind in #2024. This also massively simplifies the complex build steps. HydeFront now only contains the compiledapp.cssfile to serve through the CDN. And technically we may even consider changing this to load from the file inhydephp/hyde, depending on if step two in #2024 reduces the need for this package.