-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Improve the Vite integration #2060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2060 +/- ##
====================================================
Coverage 100.00% 100.00%
- Complexity 1932 1937 +5
====================================================
Files 196 196
Lines 5141 5154 +13
====================================================
+ Hits 5141 5154 +13 ☔ View full report in Codecov by Sentry. |
babe24b
to
30b0939
Compare
fa73114
to
a511976
Compare
40d186d
to
b048fae
Compare
protected const CSS_EXTENSIONS = ['css', 'less', 'sass', 'scss', 'styl', 'stylus', 'pcss', 'postcss']; | ||
protected const JS_EXTENSIONS = ['js', 'jsx', 'ts', 'tsx']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is seriously overkill, but it doesn't really add any more complexity to add all these. While they might not work unless more media file extensions are registered, adding all these here future proofs things without needing to support customization here.
Targets #2006
HYDE_SERVER_VITE
environment variableWe need this to print the start message. Instead, it renames the variable to be more clear it's internalEdit: Fixed by just touching the hotfile right away