-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Improve the Vite integration #2060
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
748664d
Remove unnecessary comment
caendesilva df47004
Unwrap function call
caendesilva f0029d1
Extract helper method from code comment
caendesilva dece097
Add strict types declaration
caendesilva 5e7c05c
Convert concatenation to a scalar values
caendesilva 4f5d228
Replace qualifier with an import
caendesilva 5e653a9
Add inverse test
caendesilva 5508d35
Improve confidence of test
caendesilva 079913d
Move up and improve test
caendesilva ecbf8bd
Extract helper methods
caendesilva 029a0c6
Apply fixes from StyleCI
StyleCIBot aab895a
Add todo
caendesilva 3501102
Annotate the array types
caendesilva 0e94056
Extract helper methods
caendesilva 7e0016b
Better document the Vite system
caendesilva 30b0939
Swap section order
caendesilva a511976
Support all CSS extensions like Laravel Vite uses
caendesilva 7230be5
Improve accuracy of test
caendesilva 59979e3
Use else if instead of if
caendesilva 06d9641
Revert "Use else if instead of if"
caendesilva da2ba15
Add more tests
caendesilva d5ec63d
Extract helper to format the asset path
caendesilva 4bc0f52
Use static instead of self
caendesilva 8af55ed
Add helper to get single asset
caendesilva fb3865c
Simplify test
caendesilva bf88379
Throw exception if the asset type is not supported
caendesilva b048fae
Use only hotfiles instead of internal environment variable
caendesilva 9ffbeed
Extract constant for CSS extensions
caendesilva f418e2b
Support more JavaScript extensions
caendesilva 83264ca
Extract helper method for repeated code
caendesilva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is seriously overkill, but it doesn't really add any more complexity to add all these. While they might not work unless more media file extensions are registered, adding all these here future proofs things without needing to support customization here.