pool: use Executor trait instead of concrete type
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
force-pushed
the
pool/exec-trait
branch
from
b388617 to
6549d98
Compare
Alternative to hyperium#24. Currently, `Pool` cannot be used at all. It requires a concrete `Exec`, and that is private. The hyperium#24 PR simply made `Exec` public. However, there is already other things in this crate that require an `Exec` (`legacy::Client`). This adapts `Pool` to follow the same pattern as used for `Client`, taking in a trait. This change is NOT a breaking change, as `Pool` cannot be used at all currently, so no one could be broken.
howardjohn
force-pushed
the
pool/exec-trait
branch
from
6549d98 to
d241660
Compare
seanmonstar
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #24.
Currently,
Poolcannot be used at all. It requires a concreteExec, and that is private. The #24 PR simply madeExecpublic. However, there is already other things in this crate that require anExec(legacy::Client).This adapts
Poolto follow the same pattern as used forClient, taking in a trait.This change is NOT a breaking change, as
Poolcannot be used at all currently, so no one could be broken.