Fix fill pk schedule to run on the intended times #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `*` overrides anything that follows.
marcospri
commented
Sep 8, 2023
| @@ -55,7 +55,7 @@ | |||
| "fill-annotations-pk": { | |||
| "options": {"expires": 30}, | |||
| "task": "h.tasks.annotations.fill_pk_and_user_id", | |||
| "schedule": crontab(hour="*,9-12", minute="*/15"), | |||
| "schedule": crontab(hour="9-12", minute="*/15"), | |||
There was a problem hiding this comment.
My ideal plan was to avoid high load times. I don't think it matter that much now that has been running for a while let's stick to the plan.
There was a problem hiding this comment.
I haven't touched cron in a long time, remind me what this change does?
There was a problem hiding this comment.
I guess the thing here is that *,9-12 is the same as just *, when the intention was for it to be 9-12, but correct me if I'm wrong Marcos
There was a problem hiding this comment.
Yeah my plan was:
https://crontab.guru/#/15_9-12_**
At every 15th minute past every hour from 9 through 12.”
but I had:
https://crontab.guru/#/15_,9-12___*
“At every 15th minute past every hour and every hour from 9 through 12.”
acelaya
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
*overrides anything that follows.