Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill pk schedule to run on the intended times #350

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fix fill pk schedule to run on the intended times #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion h_periodic/h_beat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"fill-annotations-pk": {
"options": {"expires": 30},
"task": "h.tasks.annotations.fill_pk_and_user_id",
"schedule": crontab(hour="*,9-12", minute="*/15"),
"schedule": crontab(hour="9-12", minute="*/15"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My ideal plan was to avoid high load times. I don't think it matter that much now that has been running for a while let's stick to the plan.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't touched cron in a long time, remind me what this change does?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the thing here is that *,9-12 is the same as just *, when the intention was for it to be 9-12, but correct me if I'm wrong Marcos

Copy link
Member Author

@marcospri marcospri Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah my plan was:

https://crontab.guru/#/15_9-12_**

At every 15th minute past every hour from 9 through 12.”

but I had:

https://crontab.guru/#/15_,9-12___*

“At every 15th minute past every hour and every hour from 9 through 12.”

"kwargs": {"batch_size": 10000},
},
"report-sync-annotations-queue-length": {
Expand Down