Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to create LMSUserAssignmentMembership #6758

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Migration to create LMSUserAssignmentMembership #6758

merged 1 commit into from
Oct 8, 2024

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Oct 7, 2024 •
edited
Loading

@marcospri marcospri changed the title Migration to crate LMSUserAssignmentMembership Migration to create LMSUserAssignmentMembership Oct 7, 2024
@marcospri marcospri marked this pull request as ready for review October 8, 2024 07:20
@marcospri marcospri mentioned this pull request Oct 8, 2024
Merged
@marcospri marcospri force-pushed the sync-grades-migration branch from b515ead to 3261289 Compare October 8, 2024 07:41
@marcospri marcospri requested a review from acelaya October 8, 2024 08:17
@acelaya
Copy link
Contributor

acelaya commented Oct 8, 2024

Are we currently using assignment_membership only for LTI 1.3 assignments?

Is the plan to migrate everything to lti_user_assignment_membership at some point, or does it serve a different purpose?

acelaya
acelaya approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcospri
Copy link
Member Author

Are we currently using assignment_membership only for LTI 1.3 assignments?

Is the plan to migrate everything to lti_user_assignment_membership at some point, or does it serve a different purpose?

The goal is to migrate to the LMSUser/LMSCourse ones eventually. The first step will be the queries made for the dashboard.

@marcospri marcospri merged commit 8c962b8 into main Oct 8, 2024
9 checks passed
@marcospri marcospri deleted the sync-grades-migration branch October 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelaya acelaya acelaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospri @acelaya