Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model definition for LMSUserAssignmentMembership #6759

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Oct 7, 2024

For:

Migration on:

Testing instruction and more context over:


This is mostly a duplicate of AssignmentMembership but that table has a composite primary key that makes changes to the schema more challenging.

The new table continues the same line of work as LMSCourseMembership and similar tables.

It also includes the lti_v11_lis_result_sourcedid column to store the grading ID of the user in one assignment to enable participation grading in LTI1.1

)
assignment = sa.orm.relationship("Assignment", foreign_keys=[assignment_id])
assignment = relationship("Assignment", foreign_keys=[assignment_id])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted the existing model to the new SQLA 2.0 style definition.

"""What role the user plays in the assignment."""


class LMSUserAssignmentMembership(CreatedUpdatedMixin, Base):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the new model.

@marcospri marcospri marked this pull request as ready for review October 8, 2024 08:18
@marcospri marcospri requested a review from acelaya October 8, 2024 08:18
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from sync-grades-migration to main October 8, 2024 12:53
This is mostly a duplicate of AssignmentMembership but that table has a
composed primary key that makes changes to the schema more challenging.

The new table continues the same line of work as LMSCourseMembership and
similar tables.

It also includes the `lti_v11_lis_result_sourcedid` column to store the
grading ID of the user in one assignment to enable participation grading
in LTI1.1
@marcospri marcospri merged commit 48c97f4 into main Oct 8, 2024
9 checks passed
@marcospri marcospri deleted the sync-grades-model branch October 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants