-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model definition for LMSUserAssignmentMembership #6759
Conversation
b515ead
to
3261289
Compare
f35b944
to
6d33459
Compare
) | ||
assignment = sa.orm.relationship("Assignment", foreign_keys=[assignment_id]) | ||
assignment = relationship("Assignment", foreign_keys=[assignment_id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted the existing model to the new SQLA 2.0 style definition.
"""What role the user plays in the assignment.""" | ||
|
||
|
||
class LMSUserAssignmentMembership(CreatedUpdatedMixin, Base): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the new model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is mostly a duplicate of AssignmentMembership but that table has a composed primary key that makes changes to the schema more challenging. The new table continues the same line of work as LMSCourseMembership and similar tables. It also includes the `lti_v11_lis_result_sourcedid` column to store the grading ID of the user in one assignment to enable participation grading in LTI1.1
6d33459
to
034cefc
Compare
For:
Migration on:
Testing instruction and more context over:
This is mostly a duplicate of AssignmentMembership but that table has a composite primary key that makes changes to the schema more challenging.
The new table continues the same line of work as LMSCourseMembership and similar tables.
It also includes the
lti_v11_lis_result_sourcedid
column to store the grading ID of the user in one assignment to enable participation grading in LTI1.1