Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release G.5.4 / H.2.4 #505

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Release G.5.4 / H.2.4 #505

merged 5 commits into from
Jan 19, 2024

Conversation

shamlian
Copy link
Collaborator

@shamlian shamlian commented Jan 9, 2024

Changelog (from G.5.3/H.2.3)

Core Robot

Webserver

Power Management

  • Robot will now change its light ring to "spinning red" when the battery level dips below 3%, and will explicitly call the /robot_power service when it falls below 2%.

ROS 2

Actions

@shamlian shamlian self-assigned this Jan 9, 2024
@shamlian
Copy link
Collaborator Author

shamlian commented Jan 9, 2024

note: "latest" redirects are not yet live. Won't merge until they are.

Copy link
Collaborator

@brianabouchard brianabouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but otherwise looks good to me!

@@ -63,10 +63,10 @@ The LEDs expose internal state information about the robot, but can also be over
| Device is connected to <br> robot’s Access Point page. | Robot downloading <br> update file | Robot updating firmware <br> Do not remove from dock | Update successful |

### While Operating
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be a spacing issue with the table that is squishing three of the gifs. Looks like it does that on the current page as well, but only to one of them. At first glance, I cannot identify any issues in the code. It may be this section needs a second table like in the "While Connecting to Wi-Fi" section
Screenshot 2024-01-09 at 6 47 06 PM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blurg.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This squishing is thanks to markdown tables wanting to be smart, I think. I am not enough of a CSS expert to fix it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I can do is to increase the maximum width of the site, so that it looks good if you have a wide monitor. I could also make the images smaller. I will try a few other things before giving up. ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed d4be417 ; what do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news, this totally fixed it on Chrome! Looks great there...bad news, on Safari it is worse
Screenshot 2024-01-10 at 9 32 08 PM

But I can sacrifice since I'm probably the only person who uses Safari :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked Firefox and it looks great there, too. Apparently Safari has like ~20% share on the browser market, so we shouldn't be flip about it. The only other idea I have is to make a table of tables; maybe if I do that, instead of squooshing the cells, it might make line breaks happen?

Copy link
Collaborator Author

@shamlian shamlian Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other other idea I have is to make each row a preformatted image, but that will be a real pain to maintain.

docs/releases/overview.md Outdated Show resolved Hide resolved
@slowrunner
Copy link

Perhaps the docs on "approaching 0%" need to reflect the robot issuing the /robot_power action.

@shamlian
Copy link
Collaborator Author

Perhaps the docs on "approaching 0%" need to reflect the robot issuing the /robot_power action.

Good point. I will do that.

@shamlian shamlian merged commit a4091bb into main Jan 19, 2024
@shamlian shamlian deleted the shamlian/release_G.5.4_G.2.4 branch January 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants