-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release G.5.4 / H.2.4 #505
Conversation
note: "latest" redirects are not yet live. Won't merge until they are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, but otherwise looks good to me!
@@ -63,10 +63,10 @@ The LEDs expose internal state information about the robot, but can also be over | |||
| Device is connected to <br> robot’s Access Point page. | Robot downloading <br> update file | Robot updating firmware <br> Do not remove from dock | Update successful | | |||
|
|||
### While Operating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there might be a spacing issue with the table that is squishing three of the gifs. Looks like it does that on the current page as well, but only to one of them. At first glance, I cannot identify any issues in the code. It may be this section needs a second table like in the "While Connecting to Wi-Fi" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blurg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This squishing is thanks to markdown tables wanting to be smart, I think. I am not enough of a CSS expert to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I can do is to increase the maximum width of the site, so that it looks good if you have a wide monitor. I could also make the images smaller. I will try a few other things before giving up. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed d4be417 ; what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cc @Rebecca-iRobot )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked Firefox and it looks great there, too. Apparently Safari has like ~20% share on the browser market, so we shouldn't be flip about it. The only other idea I have is to make a table of tables; maybe if I do that, instead of squooshing the cells, it might make line breaks happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other other idea I have is to make each row a preformatted image, but that will be a real pain to maintain.
Perhaps the docs on "approaching 0%" need to reflect the robot issuing the /robot_power action. |
Good point. I will do that. |
Changelog (from G.5.3/H.2.3)
Core Robot
Webserver
Power Management
ROS 2
Actions