Add browser auth integration test #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-polinsky
requested review from
calebmshafer,
evelynpreslar-bentley and
aruniverse
as code owners
|
I believe I can refine the way playwright binaries are downloaded... Was able to reduce the downloading of binaries by one step. It would be nice if we had agents/machines with these binaries pre-installed. |
aruniverse
reviewed
Mar 7, 2023
There was a problem hiding this comment.
youre the mvp! overall looks good, few comments:
- you might need to rebase to update the first few commits, leaking your personal account.
- can you update the readme with instructions on how to run the tests?
- can you update the npmignore to make sure we dont accidentally deliver these test files?
aruniverse
reviewed
Mar 8, 2023
aruniverse
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add playwright tests for Browser based authentication, both via redirect and via popup.
Closes #101