-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-6649: Added support for spell checking #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
spellcheck
branch
from
September 28, 2023 11:10
58e00e3
to
1d83968
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
2 tasks
alongosz
reviewed
Oct 5, 2023
src/contracts/Repository/Values/Content/Search/SearchResult.php
Outdated
Show resolved
Hide resolved
6 tasks
kisztof
approved these changes
Oct 17, 2023
6 tasks
konradoboza
approved these changes
Dec 5, 2023
src/contracts/Repository/Values/Content/Search/SpellcheckResult.php
Outdated
Show resolved
Hide resolved
…t.php Co-authored-by: Konrad Oboza <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6
Introduction
Added API to execute spell checking on search phrase and suggest potential alternatives for the user. Typical use case for this API is is "Did you mean X ?" functionality:
Similar feature implementation in Ibexa DXP:
Usage example
API changes summary
\Ibexa\Contracts\Core\Repository\Values\Content\Query\Spellcheck
and\Ibexa\Contracts\Core\Repository\Values\Content\Search\SpellcheckResult
classes\Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchResult::$spellSuggestion
property.\Ibexa\Contracts\Core\Repository\Values\Content\Query::$spellcheck
property type frombool
to\Ibexa\Contracts\Core\Repository\Values\Content\Query\Spellcheck|null
.Supported search engines
Spellcheck API is supported by
solr
andelasticsearch
search engines. However suggestions might be differ between search engines and highly depends on search engine settings. More details in search engine specific PRs:Checklist:
$ composer fix-cs
).@ibexa/php-dev
for back-end changes and/or@ibexa/javascript-dev
for front-end changes).