Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6649: Added support for spell checking #32

Merged
merged 2 commits into from
Dec 5, 2023
Merged

IBX-6649: Added support for spell checking #32

merged 2 commits into from
Dec 5, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 28, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6649
Type feature
Target Ibexa version v4.6
BC breaks no

Depends on ibexa/core#276 Needed for ibexa/admin-ui#923

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Sep 28, 2023
Merged
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested a review from a team December 5, 2023 12:45
@adamwojs adamwojs marked this pull request as ready for review December 5, 2023 12:45
@konradoboza konradoboza requested a review from a team December 5, 2023 14:57
@adamwojs adamwojs merged commit 9f1c6d1 into main Dec 5, 2023
10 of 14 checks passed
@adamwojs adamwojs deleted the ibx_6649 branch December 5, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p left review comments

@konradoboza konradoboza konradoboza approved these changes

Assignees

@kisztof kisztof

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @Steveb-p @konradoboza @kisztof @ViniTou