Fixed incorrect type-hint for Repository Exceptions contracts #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Oct 9, 2023
ciastektk
approved these changes
Oct 9, 2023
kisztof
approved these changes
Oct 9, 2023
webhdx
approved these changes
Oct 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5+I've noticed by accident that type-hints on some contract-level services don't type-hint throwing Exception contracts, but rather implementation, which then causes incorrect PHPDoc block being generated by IDE for API usages.
There's more to it, but I focused on contracts for now.
Checklist:
$ composer fix-cs).