Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved exception message for a non-unique language code #281

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Improved exception message for a non-unique language code #281

merged 1 commit into from
Oct 11, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 11, 2023 •
edited
Loading

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.6+
BC breaks no

Added language code to exception message if provided value is non-unique.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs adamwojs requested a review from a team October 11, 2023 16:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team October 11, 2023 17:26
@alongosz alongosz requested a review from a team October 11, 2023 17:55
@adamwojs
Copy link
Member Author

Thank you for code review @konradoboza & @alongosz 😉

@adamwojs adamwojs merged commit 0ef85fa into main Oct 11, 2023
23 checks passed
@adamwojs adamwojs deleted the non_unique_language_code_exception branch October 11, 2023 18:19
@mnocon mnocon mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @alongosz @konradoboza