Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8534: Cleaned up deprecations - batch 2 #456

Merged
merged 36 commits into from
Dec 10, 2024
Merged

IBX-8534: Cleaned up deprecations - batch 2 #456

merged 36 commits into from
Dec 10, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Nov 20, 2024 •
edited
Loading

This was referenced Nov 21, 2024
Merged
Closed
@ViniTou ViniTou force-pushed the ibx-8534-core-v5-p2 branch from 8b0532b to 655ebf3 Compare November 22, 2024 09:42
This was referenced Dec 2, 2024
Merged
Merged
@ViniTou ViniTou requested a review from a team December 3, 2024 14:45
@ViniTou ViniTou changed the title IBX-8534: Cleaned up deprecations - batch 2 [TMP] IBX-8534: Cleaned up deprecations - batch 2 Dec 3, 2024
Steveb-p
Steveb-p approved these changes Dec 4, 2024
View reviewed changes
src/lib/Event/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/Helper/RelationProcessor.php Outdated Show resolved Hide resolved
src/lib/Repository/Helper/RelationProcessor.php Outdated Show resolved Hide resolved
alongosz
alongosz approved these changes Dec 4, 2024
View reviewed changes
src/lib/Persistence/Cache/TrashHandler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Cache/TrashHandler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Bookmark/Gateway/DoctrineDatabase.php Show resolved Hide resolved
@alongosz alongosz requested a review from a team December 4, 2024 11:10
ViniTou added 16 commits December 10, 2024 12:10
@ViniTou
Undeprecated SectionService::countAssignedContents as it is used by a…
441fe55 
…dminUI and there is no replacment for it
@ViniTou
dropped \Ibexa\Core\Helper\FieldHelper::getFieldDefinition
fac457a
@ViniTou
dropped \Ibexa\Core\FieldType\StorageGateway
56fede6
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\Content\ContentInfo::STATUS…
6bf3701 
…_ARCHIVED
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\Content\ContentInfo::$isPub…
d6837f8 
…lished
@ViniTou
dropped $name from bookmarks
330d764
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\Content\Handler::loadRelations
f9538e8
@ViniTou
dropped Identity contracts
e603ba4
@ViniTou
undeprecated count in Section method
f32bb8e
@ViniTou
Inject TransactionHandler into repository
d09af34
@ViniTou
dropped imageValue::path
ca01544
@ViniTou
dropped imageValue::path
395e685
@ViniTou
dropped \Ibexa\Core\FieldType\Image\Value::fromString
66ea9d7
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\Content\LoadStruct
dc6f034
@ViniTou
dropped \Ibexa\Core\Persistence\Cache\PersistenceLogger::getCount
1ff0dfd
@ViniTou
dropped \Ibexa\Contracts\Core\Repository\PasswordHashService
33d4026
ViniTou added 17 commits December 10, 2024 12:11
@ViniTou
Revert "dropped \Ibexa\Core\FieldType\Image\Value::fromString"
23ca5e9 
This reverts commit 5e433442b901d6e7e2d875a68160c444fa3fe38a.
@ViniTou
undeprecated fromString method
bc2dfc0
@ViniTou
dropped Location::pathIdentificationString
0104223
@ViniTou
dropped markSubtreeModified & updateSubtreeModificationTime
bba863f
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\FieldType\IsEmptyValue
70608da
@ViniTou
dropped Indexer::createSearchIndex
c873aa8
@ViniTou
dropped \Ibexa\Contracts\Core\Persistence\User\Handler::loadPoliciesB…
29eee9f 
…yUserId
@ViniTou
dropped \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criteri…
9fc82f1 
…on\Location\IsMainLocation::createFromQueryBuilder
@ViniTou
dropped \Ibexa\Core\Repository\Helper\RoleDomainMapper
4d27bdd
@ViniTou
dropped Ibexa\Core\Repository\Helper\NameSchemaService
97d9c77
@ViniTou
dropped \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criteri…
91354c2 
…on\Location\Priority::createFromQueryBuilder
@ViniTou
dropped Location::SORT_FIELD_MODIFIED_SUBNODE
184aa81
@ViniTou
replaced abstract Criterion with CriterionInterface
592aabb
@ViniTou
Fixed Deprecations related code after rebase
97ac334
@ViniTou
Fixed RepositoryFactory
fa189c2
@ViniTou
Fixed phpstan issues mostly related to Criterion interface - all othe…
8f97013 
…r criterions interfaces now extends base content/query criterion and typehints are against it.
@ViniTou
Cleanup baseline
1440e9c
@ViniTou ViniTou force-pushed the ibx-8534-core-v5-p2 branch from 2c5c1d8 to d8e42cf Compare December 10, 2024 11:11
@ViniTou ViniTou force-pushed the ibx-8534-core-v5-p2 branch from d8e42cf to d935537 Compare December 10, 2024 11:57
@ViniTou ViniTou changed the title [TMP] IBX-8534: Cleaned up deprecations - batch 2 IBX-8534: Cleaned up deprecations - batch 2 Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud

@alongosz alongosz merged commit 625f7b7 into main Dec 10, 2024
13 of 15 checks passed
@alongosz alongosz deleted the ibx-8534-core-v5-p2 branch December 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @Steveb-p @alongosz @konradoboza @mikadamczyk @tischsoic