Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8534: Changed typehint from abstract Criterion to CriterionInterface #80

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Nov 21, 2024

🎫 Issue IBX-8534

Related PRs:

Description:

For QA:

Documentation:

@ViniTou ViniTou force-pushed the ibx-8534-core-batch-2 branch from c69a23a to 207b3b0 Compare November 21, 2024 16:02
@ViniTou ViniTou changed the title IBX-8534: Changed typehint from abstract Criterion to CriterionInterface [TMP] IBX-8534: Changed typehint from abstract Criterion to CriterionInterface Dec 3, 2024
@alongosz alongosz requested a review from a team December 4, 2024 11:19
@ViniTou ViniTou force-pushed the ibx-8534-core-batch-2 branch from d02dae4 to 8220076 Compare December 10, 2024 13:27
@ViniTou ViniTou changed the title [TMP] IBX-8534: Changed typehint from abstract Criterion to CriterionInterface IBX-8534: Changed typehint from abstract Criterion to CriterionInterface Dec 10, 2024
@ViniTou ViniTou force-pushed the ibx-8534-core-batch-2 branch from 15735a2 to 6bd98d2 Compare December 10, 2024 13:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ViniTou ViniTou merged commit 4248a31 into main Dec 10, 2024
16 of 17 checks passed
@ViniTou ViniTou deleted the ibx-8534-core-batch-2 branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants