Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Toggle for Disabling Publish Joint by Topic #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

marfanr
Copy link
Contributor

@marfanr marfanr commented Jun 13, 2024

Jira Link:

Description

Add a toggle to disable publishing joint states to Tachimawari via the topic /walking/disable_walking with std_msgs::msg::Bool type to prevent Aruku from always publishing "walk ready" when no motion is being played

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@borednuna borednuna force-pushed the feature/add-disable-publish-joint-by-topic branch from 11c90bf to cee3f8f Compare June 16, 2024 08:33
src/aruku/walking/node/walking_node.cpp Outdated Show resolved Hide resolved
src/aruku/walking/node/walking_node.cpp Outdated Show resolved Hide resolved
include/aruku/walking/node/walking_node.hpp Outdated Show resolved Hide resolved
src/aruku/walking/node/walking_node.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants