Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refresh button refetches courses #750

Merged
merged 7 commits into from
Oct 27, 2023
Merged

fix: refresh button refetches courses #750

merged 7 commits into from
Oct 27, 2023

Conversation

ap0nia
Copy link
Collaborator

@ap0nia ap0nia commented Oct 19, 2023 •
edited by MinhxNguyen7
Loading

Description

Refresh button re-fetches courses

Issues

Closes #736

@ap0nia ap0nia added the no deploy skip staging label Oct 19, 2023
@ap0nia ap0nia requested a review from EricPedley October 19, 2023 18:31
@github-actions github-actions bot requested a review from Voark October 19, 2023 18:31
@MinhxNguyen7 MinhxNguyen7 removed the no deploy skip staging label Oct 19, 2023
MinhxNguyen7
MinhxNguyen7 requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still nothing seems to happen when I click the refresh button. Not sure if I'm missing something

@ap0nia ap0nia requested a review from MinhxNguyen7 October 19, 2023 23:25
@ap0nia
Copy link
Collaborator Author

ap0nia commented Oct 19, 2023

There were multiple websoc caches in the app 🤦

KevinWu098
KevinWu098 reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx Outdated Show resolved Hide resolved
@MinhxNguyen7 @KevinWu098
Remove console.log
0badb1e 
Co-authored-by: Kevin Wu <[email protected]>
MinhxNguyen7
MinhxNguyen7 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think the multiple caches might've been me. I vaguely remember extracting part of helpers into course-helpers, but I probably forgot to delete the old stuff. I'll make an issue for that.

@MinhxNguyen7 MinhxNguyen7 mentioned this pull request Oct 26, 2023
Closed
@EricPedley
Copy link
Member

Bruh why does it still say there are conflicts 😭

@EricPedley EricPedley self-requested a review October 27, 2023 02:35
EricPedley
EricPedley approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving my own additions to the PR to give me the green merge button (?)

@EricPedley EricPedley requested review from KevinWu098 and MinhxNguyen7 and removed request for Voark October 27, 2023 02:36
@EricPedley
Copy link
Member

EricPedley commented Oct 27, 2023 •
edited
Loading

needs another review for nice green merge button

KevinWu098
KevinWu098 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@KevinWu098 KevinWu098 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting @EricPedley on this one! Gonna leave the final merge to someone else though, since I haven’t looked at the code much 🤭

@EricPedley EricPedley merged commit 31a8c7e into main Oct 27, 2023
6 checks passed
@EricPedley EricPedley deleted the fix-refresh branch October 27, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinWu098 KevinWu098 KevinWu098 approved these changes

@EricPedley EricPedley EricPedley approved these changes

@MinhxNguyen7 MinhxNguyen7 Awaiting requested review from MinhxNguyen7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh button doesn't do anything
4 participants
@ap0nia @EricPedley @MinhxNguyen7 @KevinWu098