Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom event to the route #853

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Add custom event to the route #853

merged 2 commits into from
Jan 17, 2024

Conversation

JacE070
Copy link
Contributor

@JacE070 JacE070 commented Jan 16, 2024

Summary

Add custom events to the route

Test Plan

Tested manually

Issues

Closes #819

@JacE070 JacE070 requested a review from KevinWu098 January 16, 2024 06:49
@JacE070 JacE070 marked this pull request as ready for review January 16, 2024 06:58
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the comment on reactivity.

apps/antalmanac/src/components/Map/Map.tsx Show resolved Hide resolved
@KevinWu098 KevinWu098 self-requested a review January 17, 2024 20:24
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will be finished up by #855

@KevinWu098 KevinWu098 merged commit 53d364f into main Jan 17, 2024
6 checks passed
MinhxNguyen7 pushed a commit that referenced this pull request Jan 26, 2024
@EricPedley EricPedley deleted the customEventRoute branch February 6, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making Custom Event into the Map route
2 participants