Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Custom Events Loading Onto Map #855

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

adcockdalton
Copy link
Collaborator

Summary

  1. Add proper listeners for custom events updating in a manner analogous to that of classes in the Map directory

Test Plan

  1. View map
  2. Add new custom event with location (try RH, it's one of the acceptable and nearby ones)
  3. See if change is reflected
  4. See if change reflects when saved and you visit antalmanac.com/map

Issues

Closes #813

Future Followup

  1. Not all locations are recognized for custom events on the map even though they are for classes (BS3, for example) and some don't even read on the calendar
  2. Routes do not work for custom events (it is difficult to order them correctly with the classes due to how the indexes work)

@github-actions github-actions bot requested a review from JacE070 January 17, 2024 07:37
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Functionality is good, bug appears fixed. Just a comment on code quality/code duplication!

apps/antalmanac/src/components/Map/Map.tsx Outdated Show resolved Hide resolved
@KevinWu098
Copy link
Member

For the future followup, I've opened #856 to address point 1 (good catch!), and for point 2, that should be added in #853

@KevinWu098 KevinWu098 self-requested a review January 24, 2024 21:45
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💖

@EricPedley EricPedley merged commit 3bd7386 into main Jan 24, 2024
6 checks passed
@EricPedley EricPedley deleted the fix-custom-event-map-load branch January 24, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Events don't load initially onto Map
3 participants