Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lag when going back from search results #902

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix lag when going back from search results #902

merged 1 commit into from
Feb 11, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Feb 11, 2024

Summary

  • This has been annoying me for the past few months so I ran a bisect last night and located the culprit PR (Thinner section table scroll bar #738)
  • Moved the GlobalStyles from the SectionTable to the CourseRenderPane so there should only be one of them in existence now and not a hundred
    • kind of wild that was the issue

before:

lag.before.mp4

after:

after.mp4

Test Plan

Try on both staging and prod:

  1. Load a bunch of search results e.g. i've been searching COMPSCI and scrolling down until I reach the research classes
  2. Click back
  3. Compare how long it takes

Issues

Closes #790

@KevinWu098
Copy link
Member

Wait if that's the fix this is so goated

Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So goated. Based use of git bisect. Banger PR. LGTM tested locally.

@js0mmer js0mmer merged commit 8adfee1 into main Feb 11, 2024
6 checks passed
@js0mmer js0mmer deleted the fix-back-lag branch February 11, 2024 20:12
@MinhxNguyen7
Copy link
Member

Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button is slow for big searches
3 participants