-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ add filtering by restriction code to WebSoc endpoint #130
feat: ✨ add filtering by restriction code to WebSoc endpoint #130
Conversation
🤤 |
Will start writing the feature with this staging instance 🫡, hopefully sus out some bugs while I'm at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough for initial testing. However, this only filters out requests that go through the cache; requests that result in invoking the WebSoc proxy aren't filtered out properly.
cc: @KevinWu098 (stakeholder)
I believe filtering should work for the WebSoc proxy now! |
…restriction-code-to-websoc-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good at a cursory glance! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Summary
Added filtering by restriction code to websoc REST & GraphQL endpoints using the
excludeRestrictionCodes
parameter.Example queries:
To exclude sections that include restriction code 'A'
To exclude sections that include restriction code 'X' or 'L' (or both)
Issues
Closes #122