Added an update example script #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows fleet update of robots Signed-off-by: Christian Ege <[email protected]>
This script provides a way for updating an O3D3xx via command line Signed-off-by: Christian Ege <[email protected]>
Signed-off-by: Christian Ege <[email protected]>
cfreundl
reviewed
Dec 15, 2017
| @@ -15,7 +15,8 @@ | |||
| author_email = '[email protected]', | |||
| license = 'MIT', | |||
| packages = ['o3d3xx', 'o3d3xx.rpc', 'o3d3xx.pcic'], | |||
| install_requires = ['future'], | |||
| scripts = ['scripts/o3d3xx-updater.py'], | |||
| install_requires = ['future','requests'], | |||
There was a problem hiding this comment.
I think I would like to avoid that the requests library is becoming a mandatory prerequisite for the whole o3d3xx-python package.
There was a problem hiding this comment.
You are right. I am quite unsure if the updater fits very well into this lib or is it worth to create an own project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script allows a basic software update. The handling of the right mode should be handled outside of this script. The original implementation was not working reliable.