Fix for Netty connection cleanup bug #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e automatically closed when idle as with inbound connections
…ot the channel context. Closign the connection should cascade and close both session and Netty channel
…e automatically closed when idle as with inbound connections
…ot the channel context. Closign the connection should cascade and close both session and Netty channel
…to netty-connection-cleanup-bug
… to prevent NPE in session summary
JSP resolvers are unable to resolve default properties on interfaces. NPEs were caused by the failure to resolve the new default methods on the ServerSession interface (e.g. `ServerSession#isUsingServerDialback()`) See this post for further details: https://stackoverflow.com/questions/35130290/property-not-found-on-type-when-using-interface-default-methods-in-jsp-el
AlexGidman
force-pushed
the
netty-connection-cleanup-bug
branch
from
f49cdef
to
5a6a16b
Compare
Fishbowler
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes session cleanup on idle
Adds idle state handling for outbound connections so that they are automatically closed when idle, as is already the case for inbound connections. Closes the connection on idle, not just the channel, to ensure that connections and sessions are cleaned up properly.
Also fixes: