Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Netty connection cleanup bug #2233

Merged
merged 13 commits into from
Aug 15, 2023
Merged

Fix for Netty connection cleanup bug #2233

merged 13 commits into from
Aug 15, 2023

Commits on Aug 4, 2023

  1. feat: add IdleState handling for outbound connections so that they ar… 

    …e automatically closed when idle as with inbound connections
    @AlexGidman
    AlexGidman committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5ce3703 View commit details
    Browse the repository at this point in the history

  2. fix: implement correct maxIdleTime in NettyOutboundConnectionHandler

    @AlexGidman
    AlexGidman committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f8c76f0 View commit details
    Browse the repository at this point in the history

  3. fix: NettyIdleStateKeepAliveHandler should call close on connection n… 

    …ot the channel context.

Closign the connection should cascade and close both session and Netty channel
    @AlexGidman
    AlexGidman committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    76c3c71 View commit details
    Browse the repository at this point in the history

  4. feat: add IdleState handling for outbound connections so that they ar… 

    …e automatically closed when idle as with inbound connections
    @AlexGidman @viv
    AlexGidman authored and viv committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e059718 View commit details
    Browse the repository at this point in the history

  5. fix: implement correct maxIdleTime in NettyOutboundConnectionHandler

    @AlexGidman @viv
    AlexGidman authored and viv committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    85e18cc View commit details
    Browse the repository at this point in the history

  6. fix: NettyIdleStateKeepAliveHandler should call close on connection n… 

    …ot the channel context.

Closign the connection should cascade and close both session and Netty channel
    @AlexGidman @viv
    AlexGidman authored and viv committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f6f76f9 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/netty-connection-cleanup-bug' in… 

    …to netty-connection-cleanup-bug
    @viv
    viv committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bcc7577 View commit details
    Browse the repository at this point in the history

  8. OF-2559: Comment to explain hard-coded startTls(false)

    @viv
    viv committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2062f82 View commit details
    Browse the repository at this point in the history

  9. fix: OF-2559 - cleanup Connection & session when channel unregistered… 

    … to prevent NPE in session summary
    @AlexGidman
    AlexGidman committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    93221e7 View commit details
    Browse the repository at this point in the history

  10. fix: OF-2559 - add null check for connection close

    @AlexGidman
    AlexGidman committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    428b371 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Fix server-session-details NPE 

    JSP resolvers are unable to resolve default properties on interfaces. NPEs were caused by the failure to resolve the new default methods on the ServerSession interface (e.g.  `ServerSession#isUsingServerDialback()`)

See this post for further details:

https://stackoverflow.com/questions/35130290/property-not-found-on-type-when-using-interface-default-methods-in-jsp-el
    @viv
    viv committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ff07c70 View commit details
    Browse the repository at this point in the history

  2. fix: OF-2559 - fix for compression pipeline position

    @AlexGidman
    AlexGidman committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5a6a16b View commit details
    Browse the repository at this point in the history

  3. fix: OF-2559 - unique names for compression handlers

    @AlexGidman
    AlexGidman committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c61ee3e View commit details
    Browse the repository at this point in the history