Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and restructure manager classes #117

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

ltoenning
Copy link
Member

⚠️ This PR depends on #116 which must be merged first ⚠️

Proposed Changes

Simplification of the manager classes:

  • Using the CoreNetwork class for network setup
  • New manager base class which initializes the logging and random generator and runs the simulation
  • For simplicity and flexibility, the entire node setup is moved into the individual manager classes
  • Using the new scenariofile classes/parser

Definition of Done (optional)

  • Feature is implemented
  • No known bugs that stops the correct execution
  • CI / CD pipeline passed
  • The code guidelines were followed
  • [ ] Unit and / or Integration tests for the new feature
  • [ ] New feature was added to the documentation -> The manager is currently not documented at all. I've already started creating documentation, but this will go into another PR.

@ltoenning ltoenning self-assigned this Sep 18, 2023
@ltoenning ltoenning force-pushed the manager_refactoring_new_manager branch from 9f2d081 to 1ae8ecb Compare September 22, 2023 06:16
@ltoenning ltoenning marked this pull request as ready for review September 22, 2023 06:23
@ltoenning ltoenning force-pushed the manager_refactoring_new_manager branch from 1ae8ecb to ecd9935 Compare September 22, 2023 08:36
@ltoenning ltoenning merged commit 2bce0e2 into iml130:main Sep 22, 2023
@ltoenning ltoenning deleted the manager_refactoring_new_manager branch September 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants