Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define fingerprint to distinguish runs #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Define fingerprint to distinguish runs #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/benchmark/tasks/run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
run_once: true
vars:
operation: run
hyperfoil_run_description: "{{ server_image }}-{{ cache_file }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't descriptive enough, but I guess it is probably fine as a default value designed to be overridden by the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we include something more here? I intended to leave this "as is" when running in the GH actions.


- name: Shutdown Infinispan server
ansible.builtin.include_role:
Expand Down
5 changes: 5 additions & 0 deletions roles/hyperfoil_agent/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ agent_java_args: "{{ undef() }}"
# a known_hosts entry for each agent
ssh_key: "benchmark"

# Defines the description of the run on the JSON output.
# We utilize this value to distinguish between server version and cache configuration on Horreum.
# By default, it can be null. If running the complete test suite, it is automatically filled.
hyperfoil_run_description: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past I have had to put "{{ undef() }}" does it work with empty string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was working, but I'll update it to "{{ undef() }}" for consistency.

But I see this weird thing when running the all_benchmarks.yml playbook. If I don't explicitly set the server_image value, the hyperfoil_run_description remains null. If I set the server_image to something, even the same value as the default, the description is created correctly.


# The rest are all described at https://github.com/Hyperfoil/hyperfoil_test

hyperfoil_controller_group: hyperfoil_controller
Expand Down
2 changes: 2 additions & 0 deletions roles/hyperfoil_agent/tasks/run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
- name: Import hyperfoil test to run
ansible.builtin.import_role:
name: hyperfoil.hyperfoil_test
vars:
run_description: "{{ hyperfoil_run_description }}"

- name: Hyperfoil test requests
ansible.builtin.include_role:
Expand Down
4 changes: 2 additions & 2 deletions roles/server/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
cache_name: benchmark
# Location of the cache configuration to use for the named cache
cache_file: files/cache.xml
# Optional way to override the server image used by the benchmar
server_image: quay.io/infinispan/server
# Optional way to override the server image used by the benchmark
server_image: "quay.io/infinispan/server:15.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we want to change this default or not... User should probably override instead if they want a specific version.

# Java VM arguments passed to the server image when running
server_java_args: "{{ undef() }}"
# Allows for automatic generation of Java Flight Recorder and download
Expand Down