-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): show error when update notebook fail #7009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source branch should be master
; the OSS-2.7
branch is used for releases.
Hi Jakub |
* docs: (WIP) updates onboarding steps for the influxdb3-java client. * chore: dry run onboarding java. Add missing semi-colon. Minor edit. * chore: run prettier:fix * docs: update wording of query requirements for Arrow. * chore: rerun linter * chore: retrigger checks
#6970) * chore: remove all component/files used by mqtt * chore: clean up in SetOrg container * chore: revert changes made to mqtt telegraf plugins * chore: empty commit for fresh pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NguyenHoangSon96 This looks good to me based on my testing, with the caveat that I would (1) add the dispatch
useCallback
dependency I mentioned and (2) that you will need to rebase agains the current master
branch, as there were some structural changes and a test update that will need to be incorporated. Thanks!
…fail' into feat/show-error-update-notebook-fail
Hi @wdoconnell. Thank you for the review 😇 |
No worries. In the future all you need to do is pull latest |
Closes #6999
UI will show error notification when the auto-update notebook call fails:
Checklist
Authors and Reviewer(s), please verify the following: