Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show error when update notebook fail #7009

Closed
wants to merge 11 commits into from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 14, 2025

Closes #6999

UI will show error notification when the auto-update notebook call fails:

Screenshot 2025-02-14 at 17 23 11

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 14, 2025
@bednar bednar removed their request for review February 18, 2025 09:20
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source branch should be master; the OSS-2.7 branch is used for releases.

@NguyenHoangSon96 NguyenHoangSon96 changed the base branch from OSS-2.7 to master February 20, 2025 06:58
@NguyenHoangSon96 NguyenHoangSon96 requested a review from a team as a code owner February 20, 2025 06:58
@NguyenHoangSon96
Copy link
Author

The source branch should be master; the OSS-2.7 branch is used for releases.

Hi Jakub
I changed the source branch to the master
Please check again

wdoconnell and others added 3 commits February 20, 2025 15:32
* docs: (WIP) updates onboarding steps for the influxdb3-java client.

* chore: dry run onboarding java.  Add missing semi-colon.  Minor edit.

* chore: run prettier:fix

* docs: update wording of query requirements for Arrow.

* chore: rerun linter

* chore: retrigger checks
#6970)

* chore: remove all component/files used by mqtt

* chore: clean up in SetOrg container

* chore: revert changes made to mqtt telegraf plugins

* chore: empty commit for fresh pipeline
@philjb philjb requested a review from wdoconnell March 4, 2025 21:43
Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NguyenHoangSon96 This looks good to me based on my testing, with the caveat that I would (1) add the dispatch useCallback dependency I mentioned and (2) that you will need to rebase agains the current master branch, as there were some structural changes and a test update that will need to be incorporated. Thanks!

@NguyenHoangSon96
Copy link
Author

Hi @wdoconnell. Thank you for the review 😇
I fixed all things you mentioned but I have messup the rebase, I'm not very familiar with using rebase
So I created new branch with all the fix
Please check this branch New branch, sorry for the inconvenience 🥹

@wdoconnell
Copy link
Contributor

Hi @wdoconnell. Thank you for the review 😇 I fixed all things you mentioned but I have messup the rebase, I'm not very familiar with using rebase So I created new branch with all the fix Please check this branch New branch, sorry for the inconvenience 🥹

No worries. In the future all you need to do is pull latest master, then git rebase -i your feature branch against master. In the interim you can close this PR, since we will address it in the other branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[notebooks]: if the autosave api returns an error, the ui still shows that the notebook saved, when it didn't
5 participants