Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show error update notebook fail #7021

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: show error update notebook fail #7021

wants to merge 4 commits into from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 6, 2025 •
edited by bednar
Loading

Closes #6999

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners March 6, 2025 08:26
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 6, 2025
@NguyenHoangSon96 NguyenHoangSon96 changed the title feat: show error update notebook fail 1 feat: show error update notebook fail Mar 6, 2025
@NguyenHoangSon96 NguyenHoangSon96 mentioned this pull request Mar 6, 2025
Closed
5 tasks
@wdoconnell
Copy link
Contributor

Remocal deployment failure. Re-running CI.

@philjb philjb requested a review from wdoconnell March 6, 2025 18:19
@wdoconnell
Copy link
Contributor

@NguyenHoangSon96 Looks like CI flaked, please force push to re-run this.

@NguyenHoangSon96
Copy link
Author

@NguyenHoangSon96 Looks like CI flaked, please force push to re-run this.

@wdoconnell
I have triggered CI. It's looking good now
Please check again

@NguyenHoangSon96 NguyenHoangSon96 requested review from wdoconnell and removed request for wdoconnell March 11, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdoconnell wdoconnell Awaiting requested review from wdoconnell

At least 1 approving review is required to merge this pull request.

Assignees

@NguyenHoangSon96 NguyenHoangSon96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[notebooks]: if the autosave api returns an error, the ui still shows that the notebook saved, when it didn't
2 participants
@NguyenHoangSon96 @wdoconnell