[MIR] Connection check for InOrbit MQTT #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-Tomas
approved these changes
May 29, 2024
There was a problem hiding this comment.
Looks like you might've branched from the changed for the previous MR
| @@ -279,6 +279,10 @@ def start(self): | |||
| except Exception: | |||
| self.logger.exception("Error reporting mission") | |||
|
|
|||
| def inorbit_connected(self): | |||
| """Check if the InOrbit MQTT session is connected.""" | |||
| return self.inorbit_sess.client.is_connected() | |||
There was a problem hiding this comment.
Not a fan of accessing RobotSession.client externally but can't think of another way. To keep in mind for future development of InOrbit Edge.
russell-inorbit
force-pushed
the
connection-check
branch
from
547ca7c to
264bcb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
🗒️ Description
This MR adds a connection check to the MQTT session within InOrbit.
cc: @anvitaupadhyay8