PLT-7591: Improved Auditor Report Upload

[EehMauro]

@coderabbitai: ignore

[amnambiar]

Note: we need to integrate changes from PR #8 here once that is approved/merged

[RSoulatIOHK]

Love the new design.

Error messages

Ok, I don't know why, but at first, the checks for the values were not happening until I clicked on Send report. And after that it would only show me one field that was wrong. I fixed them in the order requested:

• Auditor Information
  • Name
  • Website
  • Logo

And then, it showed all the other field with wrong values, and will display live the error messages of everything I filled wrong.

Wrong Regex

I don't get from the code why this Website value (example.com or www.example.com) is not ok for the regex:

[EehMauro]

Love the new design.

Error messages

Ok, I don't know why, but at first, the checks for the values were not happening until I clicked on Send report. And after that it would only show me one field that was wrong. I fixed them in the order requested:

• Auditor Information

  • Name
  • Website
  • Logo

And then, it showed all the other field with wrong values, and will display live the error messages of everything I filled wrong.

Wrong Regex

I don't get from the code why this Website value (example.com or www.example.com) is not ok for the regex:

Fixed!

[EehMauro]

Added Auditor Report Upload fields prefill with user profile

[amnambiar]

@EehMauro , Here are my thoughts -
'Auditor Report Upload' and ['Review Certification Metadata'](PR #8) are same just with Subject and Report URLs missing in the later. Rest all schema, functionalities are the same. Hence I created a common MetadataForm component to share between the two; by supplying separate configurations to build the form, and schemas (see PR #20 for latest).

Have you kept this in mind in this PR, otherwise what is your suggestion. We need to discuss over this, to reduce redundancy and make this simpler.

[amnambiar]

@EehMauro , Also I see you are not making use of schema validators like yup. Is there a particular reason why? Also, do you advocate in removing them throughout the app?

[amnambiar]

@EehMauro , Here are my thoughts - 'Auditor Report Upload' and ['Review Certification Metadata'](PR #8) are same just with Subject and Report URLs missing in the later. Rest all schema, functionalities are the same. Hence I created a common MetadataForm component to share between the two; by supplying separate configurations to build the form, and schemas (see PR #20 for latest).

Have you kept this in mind in this PR, otherwise what is your suggestion. We need to discuss over this, to reduce redundancy and make this simpler.

PR #8 was merged after a lot of integration testing / bug fixes / schema corrections 😆
If we redo the component entirely in this PR , wouldn't we have to apply the same effort here as well? I'm a bit sceptical with this 🙃

[EehMauro]

Hi @amnambiar, I can merge #20 here so I can re-use the form you made and the yup validations

[RSoulatIOHK]

Two more things but I don't know where to point it into the code but:

• The checks on the values don't start until I click a first time on "Send report"
• If I put a too long "Script Hash" like : 01234567890123456789012345678901234567890123456789012345678901234567890012345678901234567890123456789012345678901234567890123456789012345678900123456789012345678901234567890123456789012345678901234567890123456789001234567890123456789012345678901234567890123456789012345678901234567890 it never shows on the form that it is wrong but I get an error when clicking on "Send report"

[RSoulatIOHK]

Sorry, Missed this during the first review

[amnambiar]

1. reportURLs are to be sent as array of strings in report.reportURLs in the payload
2. Move Add Script to after all the the DApp Scripts (like Romain mentioned)
3. Error in form submit is retained while navigating away and coming back, even though the form is cleared. Clear errors in the form, while moving away from the page.

@EehMauro bugs/changes to be addressed here

[amnambiar]

@EehMauro , Pardon my bad. Can you please fix (1)

POST /auditor/reports expects . Can you fix that. And, the error 400 user error (Report URLs do not match) when you give urls to different PDFs are because they are basically NOT different urls to the same report file(expected).

"report": [
    "string"
  ],

[amnambiar]

@EehMauro Bugs - In Review Certification Metadata --

1. remove fields Certification Level, Subject, Report URLs
2. Add a cancel or close button to cancel the modal if he chooses to, as this is not mandatory

[amnambiar]

In Review Certification Metadata --

remove fields Certification Level, Subject, Report URLs
Add a cancel or close button to cancel the modal if he chooses to, as this is not mandatory

This is done.

[amnambiar]

LGTM now