Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add core.json to package.json exports #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimenB
Copy link

@SimenB SimenB commented Jul 24, 2023

Allows browserify/resolve@122bb64 to be just require('is-core-module/core.json')

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (77d33fb) 90.47% compared to head (83cb795) 90.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files           1        1           
  Lines          42       42           
  Branches       17       17           
=======================================
  Hits           38       38           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Jul 24, 2023

While this is certainly a technically viable resolution for resolve, I am very very very loath to add to the exposed API of is-core-module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants