Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-tag): Non-interactive components are announced as "clickable" by screen readers #1782

Conversation

git-nandor
Copy link
Contributor

@git-nandor git-nandor commented Nov 19, 2024

Remove onClick prop from Tag when callback is not provided.
Fix Progress dependency mismatch (test-locator)

Closes: INSTUI-4332

Test:
Check Tag component in the doc App with Safari and VoiceOver.
Tag should not announced as clickable (select with: control+shift+option+arrow buttons)

…s not provided. Fix Progress dependency mismatch (test-locator)

Closes: INSTUI-4332
@git-nandor git-nandor self-assigned this Nov 19, 2024
@git-nandor git-nandor marked this pull request as ready for review November 19, 2024 14:49
Copy link

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-20 09:29 UTC

@git-nandor git-nandor changed the title fix(ui-progress,ui-tag): remove onClick prop from Tag when callback i… fix(ui-tag): Non-interactive components are announced as "clickable" by screen readers Nov 19, 2024
@git-nandor git-nandor merged commit de22f76 into master Nov 20, 2024
11 checks passed
@git-nandor git-nandor deleted the INSTUI-4332_non-interactive_components_are_announced_as_clickable_by_screen_readers branch November 20, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants