-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E] Replace TEMPORARY_DISABLED by UNSUPPORTED #15946
Conversation
To completely disable the test "REQUIRES: TEMPORARY_DISABLED" is used. There can be typos, lower-case style, etc, so the disabled test may be missed by grep. To unify the mechanism to disable tests this patch adds new features for `UNSUPPORTED` to disable the test. Also updating the tests using "TEMPORARY_DISABLED".
ddd9dca
to
27083fc
Compare
sycl/test-e2e/Basic/free_function_queries/free_function_queries.cpp
Outdated
Show resolved
Hide resolved
@KornevNikita, I'm not sure I understand the problem you are trying to solve with this change.
Did I get it right that you are using grep to find disabled tests? If so, please, try using
Full list of options: https://llvm.org/docs/CommandGuide/lit.html |
The main idea is to unify the mechanism to disable tests, as this "TEMPORARY_DISABLED" is non-standard, but some work-around. We could just switch it to |
From my POV, replacing a single way (i.e.
Sorry, it looks like the right way to use |
Didn't think about that. If this works I'd prefer to proceed with it. |
It's used by a few tests in llvm-project. compiler-rt/test/builtins/Unit/gcc_personality_test.c
Other uses are in |
@bader thanks for pointing out! I'll update the PR |
@intel/dpcpp-esimd-reviewers could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, was OOO. lgtm!
@intel/llvm-gatekeepers could you please merge? |
To unify the mechanism to disable tests this patch replaces
REQUIRES: TEMPORARY_DISABLED
byUNSUPPORTED: true
to disable the test. Also updating the tests using "TEMPORARY_DISABLED".