Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Replace TEMPORARY_DISABLED by UNSUPPORTED #15946

Merged
merged 5 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// FIXME: Investigate OS-agnostic failures
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// FIXME: Investigate OS-agnostic failures
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
// UNSUPPORTED: cuda || hip
// CUDA and HIP compilation and runtime do not yet support sub-groups.
//
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/image/image_accessor_range.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// REQUIRES: aspect-ext_intel_legacy_image
// FIXME: Investigate OS-agnostic failures
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true

// UNSUPPORTED: cuda || hip
// CUDA does not support SYCL 1.2.1 images.
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/GroupAlgorithm/barrier.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Temporarily disabled due to regressions introduced by
// https://github.com/intel/llvm/pull/8412.
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true

// RUN: %{build} -o %t.out -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_80
// RUN: %{run} %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// NOTE: The feature is not yet supported, there is a discussion on the
// feasibility of tests
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
//
// Check that full compilation works:
// RUN: %clangxx -DIMPL_SUBGROUP -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %S/../popcnt.cpp -o %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/InvokeSimd/Feature/popcnt.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// NOTE: The feature is not yet supported, there is a discussion on the
// feasibility of tests
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
//
// Check that full compilation works:
// RUN: %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr -o %t.out
Expand Down
10 changes: 10 additions & 0 deletions sycl/test-e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,3 +369,13 @@ temporarily disabled due to some issue.
If you add `UNSUPPORTED` without `UNSUPPORTED-TRACKER` or `UNSUPPORTED-INTENDED`
directive, the `no-unsupported-without-tracker.cpp` test will fail, notifying
you about that.

To disable the test completely, you can use:
```
// USNUPPORTED: true
```

Note: please avoid using `REQUIRES: TEMPORARY_DISABLED` for this purpose, it's
a non-standard mechanism. Use `UNSUPPORTED: true` instead, we track
`UNSUPPORTED` tests using the mechanism described above. Otherwise the test
risks remaining untraceable.
2 changes: 1 addition & 1 deletion sycl/test-e2e/Regression/complex_global_object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
// such objects do not cause problems if the first call to SYCL is inside main
// and the last call is in global destructor.

// REQUIRES: TEMPORARY_DISABLED
// Disable test due to flacky failures
// UNSUPPORTED: true

#include <sycl/detail/core.hpp>

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Regression/event_destruction.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
// Temporarily disabled because the test is out of time
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
4 changes: 2 additions & 2 deletions sycl/test-e2e/Regression/local-arg-align.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
//
// RUN: %{run} %t.out

// https://github.com/intel/llvm/issues/10682
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/10682

//==-- local-arg-align.cpp - Test for local argument alignmnent ------------==//
//
Expand Down
3 changes: 2 additions & 1 deletion sycl/test-e2e/SpecConstants/2020/non_native/gpu.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// REQUIRES: ocloc, gpu, TEMPORARY_DISABLED
// UNSUPPORTED: true
// REQUIRES: ocloc, gpu
// UNSUPPORTED: cuda
// CUDA is not compatible with SPIR.
//
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/SubGroup/generic_reduce.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// by the reduce functions in SYCL 2020, but the standard C++ syntax is used for
// forward compatibility with future SYCL versions.
//
// REQUIRES: TEMPORARY_DISABLED
// UNSUPPORTED: true

#include "helper.hpp"
#include <complex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 477
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 486
//
// List of improperly UNSUPPORTED tests.
// Remove the CHECK once the test has been properly UNSUPPORTED.
Expand All @@ -78,13 +78,15 @@
// CHECK-NEXT: Basic/build_log.cpp
// CHECK-NEXT: Basic/code_location_e2e.cpp
// CHECK-NEXT: Basic/free_function_queries/free_function_queries.cpp
// CHECK-NEXT: Basic/free_function_queries/free_function_queries.cpp
// CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp
// CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp
// CHECK-NEXT: Basic/gpu_max_wgs_error.cpp
// CHECK-NEXT: Basic/group_async_copy.cpp
// CHECK-NEXT: Basic/host-task-dependency.cpp
// CHECK-NEXT: Basic/image/image.cpp
// CHECK-NEXT: Basic/image/image_accessor_range.cpp
// CHECK-NEXT: Basic/image/image_accessor_range.cpp
// CHECK-NEXT: Basic/image/image_accessor_readsampler.cpp
// CHECK-NEXT: Basic/image/image_accessor_readwrite.cpp
// CHECK-NEXT: Basic/image/image_accessor_readwrite_half.cpp
Expand Down Expand Up @@ -242,13 +244,16 @@
// CHECK-NEXT: Graph/RecordReplay/work_group_size_prop.cpp
// CHECK-NEXT: Graph/UnsupportedDevice/device_query.cpp
// CHECK-NEXT: GroupAlgorithm/SYCL2020/reduce_over_group_size.cpp
// CHECK-NEXT: GroupAlgorithm/barrier.cpp
// CHECK-NEXT: GroupAlgorithm/reduce_sycl2020.cpp
// CHECK-NEXT: GroupAlgorithm/root_group.cpp
// CHECK-NEXT: HierPar/hier_par_wgscope.cpp
// CHECK-NEXT: HostInteropTask/host-task-failure.cpp
// CHECK-NEXT: HostInteropTask/interop-task.cpp
// CHECK-NEXT: InOrderEventsExt/get_last_event.cpp
// CHECK-NEXT: InvokeSimd/Feature/ImplicitSubgroup/SPMD_invoke_ESIMD_external.cpp
// CHECK-NEXT: InvokeSimd/Feature/ImplicitSubgroup/popcnt.cpp
// CHECK-NEXT: InvokeSimd/Feature/popcnt.cpp
// CHECK-NEXT: InvokeSimd/Regression/ImplicitSubgroup/call_vadd_1d_spill.cpp
// CHECK-NEXT: InvokeSimd/Regression/call_vadd_1d_spill.cpp
// CHECK-NEXT: KernelAndProgram/build-log.cpp
Expand Down Expand Up @@ -437,6 +442,8 @@
// CHECK-NEXT: Regression/DAE-separate-compile.cpp
// CHECK-NEXT: Regression/acos.cpp
// CHECK-NEXT: Regression/barrier_waitlist_with_interop_event.cpp
// CHECK-NEXT: Regression/complex_global_object.cpp
// CHECK-NEXT: Regression/event_destruction.cpp
// CHECK-NEXT: Regression/get_subgroup_sizes.cpp
// CHECK-NEXT: Regression/get_subgroup_sizes.cpp
// CHECK-NEXT: Regression/image_access.cpp
Expand Down Expand Up @@ -471,7 +478,9 @@
// CHECK-NEXT: SpecConstants/2020/kernel-bundle-api.cpp
// CHECK-NEXT: SpecConstants/2020/non_native/gpu.cpp
// CHECK-NEXT: SpecConstants/2020/non_native/gpu.cpp
// CHECK-NEXT: SpecConstants/2020/non_native/gpu.cpp
// CHECK-NEXT: SpecConstants/2020/non_native/multiple-targets.cpp
// CHECK-NEXT: SubGroup/generic_reduce.cpp
// CHECK-NEXT: Tracing/code_location_queue_copy.cpp
// CHECK-NEXT: Tracing/code_location_queue_parallel_for.cpp
// CHECK-NEXT: Tracing/code_location_queue_submit.cpp
Expand Down
Loading