Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent assigning parent assets to primary assets #1302

Merged

Conversation

nas-tabchiche
Copy link
Contributor

@nas-tabchiche nas-tabchiche commented Jan 2, 2025

Users used to be able to add parent assets to a primary asset by setting its type to support, assigning parent assets, and setting its type back to primary.
This PR makes it so that it is no longer possible, and also hides the parent assets field if the asset being written is primary.

@nas-tabchiche nas-tabchiche changed the title CA 634 bypass parent asset restriction on primary assets Prevent assigning parent assets to primary assets Jan 2, 2025
Copy link
Contributor

@ab-smith ab-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

@ab-smith ab-smith merged commit 3288ac1 into main Jan 3, 2025
19 checks passed
@ab-smith ab-smith deleted the CA-634-bypass-parent-asset-restriction-on-primary-assets branch January 3, 2025 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants