New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): style enter amount for staking #3874

Closed

panteleymonchuk wants to merge 6 commits into tooling-dashboard/style-select-validator from tooling-dashboard/style-stake-amount

Contributor

panteleymonchuk commented Nov 4, 2024 •

edited

Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes: #3699

Type of change

Choose a type of change, and delete any options that are not relevant.

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

panteleymonchuk added 3 commits

November 1, 2024 21:35


          feat(wallet-dashboard): select validator.

7d16bd2


          feat(wallet-dashboard, core, wallet): add new utility functions for s…

582f55e

…take calculations and update imports


          feat(wallet-dashboard): show gas budget and final polish.

9f047e0

panteleymonchuk added tooling wallet wallet-dashboard labels

panteleymonchuk linked an issue

that may be closed by this pull request

Style staking flow enter amount screen #3699

Closed

panteleymonchuk changed the title ~~Tooling-dashboard/style-stake-amount~~ feat(wallet-dashboard): style enter amount for staking

panteleymonchuk marked this pull request as ready for review

November 6, 2024 09:03

panteleymonchuk requested review from a team as code owners

November 6, 2024 09:03

Contributor

github-actions bot commented Nov 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 9f047e0

✅ Preview: https://apps-ui-phvw928eh-iota1.vercel.app

Contributor

github-actions bot commented Nov 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 9f047e0

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-jfq3r6npz.vercel.app

Contributor

github-actions bot commented Nov 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 9f047e0

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-dhheugala.vercel.app

panteleymonchuk marked this pull request as draft

November 6, 2024 09:06

panteleymonchuk added 2 commits

November 6, 2024 13:47


          feat(wallet-dashboard): update GasSummary component and improve condi…

5f537d1

…tional rendering in StakeTxnInfo


          feat(wallet-dashboard): enhance staking dialog flow and rename compon…

f413060

…ents for clarity

panteleymonchuk marked this pull request as ready for review

November 7, 2024 09:20

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 5f537d1

✅ Preview: https://apps-ui-97e6agvp3-iota1.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 5f537d1

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-muvb6iljb.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 5f537d1

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-398rvftbg.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 5f537d1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-i7j6t6mjv.vercel.app

panteleymonchuk mentioned this pull request

feat(wallet-dashboard): style select validator #3854

Closed

6 tasks


          feat(wallet-dashboard): refactor staking dialogs and introduce Valida…

33e3089

…tor component

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 33e3089

✅ Preview: https://apps-ui-494uklq9x-iota1.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 33e3089

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-l6r14fnjk.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 33e3089

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-4bi2u34qd.vercel.app

Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: 33e3089

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-nrglzc6ok.vercel.app

cpl121 requested changes

View reviewed changes

apps/wallet-dashboard/components/Dialogs/Staking/StakeDialog.tsx

                                               />
                                           )}
                                           {step === Step.EnterAmount && (
                                               <EnterAmountView
                                                   selectedValidator={selectedValidator}
                                                   amount={amount}
+                                                  gasBudget={newStakeData?.gasBudget}
                                                   onChange={(e) => setAmount(e.target.value)}
                                                   onBack={handleBack}
                                                   onStake={handleStake}

Member

cpl121 Nov 7, 2024

we could close the dialog if everything goes well, at least until the tx details screen is done

apps/wallet-dashboard/components/Dialogs/Staking/StakeDialog.tsx

-                                  <Header title={title[step]} onClose={() => setOpen(false)} />
+                                  <Header
+                                      title={title[step]}
+                                      onClose={() => setOpen(false)}

Member

cpl121 Nov 7, 2024

we should reset the selected validator too when closing the dialog

apps/wallet-dashboard/components/Dialogs/Staking/StakedDetailsDialog.tsx

-                  const { name, commission, newValidator, isAtRisk, apy, isApyApproxZero } =
-                      useValidatorInfo(validatorAddress);
+                  const { name, commission, newValidator, isAtRisk, apy, isApyApproxZero } = useValidatorInfo({
+                      validatorAddress: validatorAddress,

Member

cpl121 Nov 7, 2024

Suggested change

      
                    validatorAddress: validatorAddress,
          
                    validatorAddress,

apps/wallet-dashboard/components/Dialogs/Staking/StakedDetailsDialog.tsx

@@ @@ -89,7 +90,7 @@ export function StakedDetailsDialog({ @@
                   }
                   function handleAddNewStake() {
-                      console.log('Stake');
+                      // pass

Member

cpl121 Nov 7, 2024

why not open the dialog to make a new stake here?

apps/wallet-dashboard/components/Dialogs/Staking/hooks/useSelectValidator.ts

+              // Copyright (c) 2024 IOTA Stiftung
+              // SPDX-License-Identifier: Apache-2.0
+              export function useSelectValidator() {

Member

cpl121 Nov 7, 2024

are we using this hook?

apps/wallet-dashboard/components/Dialogs/Staking/index.ts

@@ @@ -2,3 +2,4 @@ @@
               // SPDX-License-Identifier: Apache-2.0
               export { default as StakeDialog } from './StakeDialog';
+              export * from './StakedDetailsDialog';

Member

cpl121 Nov 7, 2024

Suggested change

      
            export * from './StakedDetailsDialog';
          
            export { default as StakedDetailsDialog } from './StakedDetailsDialog';

to follow the same format, right?

Member

VmMad Nov 13, 2024

we should keep this with the * as we agreed

panteleymonchuk force-pushed the tooling-dashboard/style-select-validator branch from 7d16bd2 to dc319da Compare

November 7, 2024 19:14

VmMad mentioned this pull request

feat(wallet-dashboard): add staking confirmation screen #4034

Closed

panteleymonchuk force-pushed the tooling-dashboard/style-select-validator branch from dc319da to f7c2c6f Compare

November 13, 2024 15:19

Contributor Author

panteleymonchuk commented Nov 14, 2024

For decrease dependencies, changes for this PR added in the #3832

All commnets fixed

panteleymonchuk closed this

begonaalvarezd deleted the tooling-dashboard/style-stake-amount branch

December 3, 2024 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling wallet wallet-dashboard