Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer): add theme switcher #4041

Merged
merged 12 commits into from
Nov 25, 2024
Merged

feat(explorer): add theme switcher #4041

merged 12 commits into from
Nov 25, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Nov 13, 2024 •
edited
Loading

Fixes #3617

Depends on #4079

@VmMad VmMad added tooling Issues related to the Tooling team explorer Issues related to the Explorer labels Nov 13, 2024
@VmMad VmMad self-assigned this Nov 13, 2024
@VmMad VmMad requested review from a team as code owners November 13, 2024 16:36
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1358dd3

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-p26a41t28.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4dd2d34

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-49cl129tu.vercel.app

brancoder
brancoder requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good we just need to fix lint issues. Im also getting prettier issues localy which dont seam to be an issue in the CI
image
nit: The color scheme of the validator icons in the Top Validators table on the homepage could be improved:
image

evavirseda
evavirseda requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the feature should be merged into a feature branch for all the dark mode-related changes not in develop, as mentioned in the parent issue #3616 🙏

@VmMad VmMad changed the base branch from develop to tooling-epic/explorer-darkmode-support November 14, 2024 16:17
@VmMad
Copy link
Member Author

VmMad commented Nov 14, 2024

Looks good we just need to fix lint issues. Im also getting prettier issues localy which dont seam to be an issue in the CI image nit: The color scheme of the validator icons in the Top Validators table on the homepage could be improved: image

The screenshot you sent from ThemedIotaLogo seems to be an issue with how prettier is configured. I'm also getting the warning but the CI isn't complaining... I fixed other linting issues btw.
And regarding the Validator Logo, that will be done in other issue

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0ad0e6c

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-akgpd4hmg.vercel.app

@VmMad VmMad mentioned this pull request Nov 19, 2024
Merged
@VmMad VmMad changed the base branch from tooling-epic/explorer-darkmode-support to tooling-epic/add-darkmode-support-to-wallet November 22, 2024 09:39
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2d4369e

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-qfcbonrgh.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2d4369e

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-1qkne4xl3.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2d4369e

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-7p5bal3ao.vercel.app

This was referenced Nov 22, 2024
Merged
Merged
Merged
evavirseda
evavirseda approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1eb2f18

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9m94dbc0g.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1eb2f18

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-pdgellcek.vercel.app

@VmMad
feat(explorer): add background to search suggestions (#4162)
70f02cf 
* feat(explorer): add backgrounds to the search suggestions

* refactor: add styles to search ui kit

* revert changes

* fix: remove unnecessary backdrop-blur
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 70f02cf

✅ Preview: https://apps-ui-6ep3wmvvw-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 70f02cf

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jph1qkdtm.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 70f02cf

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-f35y3bfpv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 21d1252

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-o16g6iunt.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 21d1252

✅ Preview: https://apps-ui-9fp4pr32u-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 21d1252

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-eq1xqpj1c.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 21d1252

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-n2184v16h.vercel.app

Base automatically changed from tooling-epic/add-darkmode-support-to-wallet to develop November 25, 2024 15:50
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d943221

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-h2addwqhz.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d943221

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-qgykqppcz.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d943221

✅ Preview: https://apps-ui-6ozfdml71-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d943221

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-2wetacax4.vercel.app

@VmMad VmMad changed the base branch from develop to tooling-epic/explorer-darkmode-support November 25, 2024 16:02
evavirseda and others added 2 commits November 25, 2024 19:35
@evavirseda
feat(explorer): add darkmode support to epoch page (#4160)
a335b67 
* feat: polish darkmode

* fix format

* feat: update imports
@VmMad
feat(explorer): improve darkmode colors for transaction page (#4158)
0861206 
* feat(explorer): improve darkmode colors for transaction page

* feat: add button to the split panes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a335b67

✅ Preview: https://apps-ui-n4hsw2vay-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a335b67

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-acy998rca.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a335b67

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-p690plka8.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0861206

✅ Preview: https://apps-ui-9e4exovq5-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0861206

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-7aq2zbz67.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0861206

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ozrj06r4e.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0861206

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ex9i6d1zx.vercel.app

@msarcev msarcev merged commit 3ed9c13 into tooling-epic/explorer-darkmode-support Nov 25, 2024
32 of 33 checks passed
@msarcev msarcev deleted the tooling-explorer/add-darkmode-support branch November 25, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@msarcev msarcev msarcev approved these changes

@brancoder brancoder Awaiting requested review from brancoder

Assignees

@VmMad VmMad

Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add darkmode/lightmode theme selection logic
4 participants
@VmMad @msarcev @brancoder @evavirseda