-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] restructure hardware config #655
Changes from all commits
68a574a
2eaf25c
edc3324
efe0225
0284311
8c2c8f8
b95ec08
1835b81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,16 @@ | ||
<?xml version="1.0"?> | ||
<launch> | ||
<arg name="robot"/> | ||
<arg name="module"/> | ||
<arg name="module_type" default="gripper"/> | ||
<arg name="component_name"/> | ||
<arg name="sim" default="false"/> | ||
|
||
<include unless="$(arg sim)" file="$(find cob_bringup)/drivers/schunk_sdhx.launch"> | ||
<arg name="component_name" value="$(arg component_name)"/> | ||
</include> | ||
<include if="$(arg sim)" file="$(find cob_bringup)/controllers/generic_controller.launch"> | ||
<arg name="robot" value="$(arg robot)"/> | ||
<arg name="module" value="$(arg module)"/> | ||
<arg name="module_type" value="$(arg module_type)"/> | ||
<arg name="component_name" value="$(arg component_name)"/> | ||
</include> | ||
</launch> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,27 @@ | ||
<?xml version="1.0"?> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still have supported robots using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. raw3-1 torso is using the legacy schunk_powercube_chain |
||
<launch> | ||
<arg name="robot"/> | ||
<arg name="module"/> | ||
<arg name="module_type"/> | ||
<arg name="component_name"/> | ||
<arg name="sim" default="false"/> | ||
|
||
<group unless="$(arg sim)"> | ||
<include file="$(find cob_bringup)/drivers/schunk_powercube_chain_driver.launch"> | ||
<arg name="robot" value="$(arg robot)"/> | ||
<arg name="module" value="$(arg module)"/> | ||
<arg name="module_type" value="$(arg module_type)"/> | ||
<arg name="component_name" value="$(arg component_name)"/> | ||
</include> | ||
<include file="$(find cob_bringup)/controllers/cob_trajectory_controller.launch"> | ||
<arg name="robot" value="$(arg robot)"/> | ||
<arg name="module" value="$(arg module)"/> | ||
<arg name="module_type" value="$(arg module_type)"/> | ||
<arg name="component_name" value="$(arg component_name)"/> | ||
</include> | ||
</group> | ||
|
||
<group if="$(arg sim)"> | ||
<include file="$(find cob_bringup)/controllers/generic_controller.launch"> | ||
<arg name="robot" value="$(arg robot)"/> | ||
<arg name="module" value="$(arg module)"/> | ||
<arg name="module_type" value="$(arg module_type)"/> | ||
<arg name="component_name" value="$(arg component_name)"/> | ||
</include> | ||
<node ns="$(arg component_name)" pkg="cob_helper_tools" type="fake_driver.py" name="fake_driver" cwd="node" respawn="false" output="screen"/> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
<?xml version="1.0" ?> | ||
<launch> | ||
|
||
<arg name="robot" default="$(optenv ROBOT !!NO_ROBOT_SET!!)"/> | ||
<arg name="pkg_hardware_config" default="$(find cob_hardware_config)"/> | ||
<arg name="dev" default="/dev/input/js0"/> | ||
<arg name="deadzone" default="0.12"/> | ||
|
||
<!-- run joystick --> | ||
<node pkg="joy" type="joy_node" name="$(anon joy_node)"> | ||
<rosparam command="load" file="$(arg pkg_hardware_config)/robots/$(arg robot)/config/joy.yaml"/> | ||
<rosparam param="dev" subst_value="True">$(arg dev)</rosparam> | ||
<rosparam param="deadzone" subst_value="True">$(arg deadzone)</rosparam> | ||
</node> | ||
|
||
</launch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep
cob4
prefix beforebase
prefix. what's your rational to change this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we are grouping by module, I'd have the "module" as prefix...grouping the launch files, too