MHC calculator change fields #1024
Open
+140
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_products_per_day fields
DanielVajnagi
approved these changes
Feb 11, 2025
|
|
||
| <div class="pb-2 input_lable mt-6"> | ||
| <%= label_tag "child_product_category", t(".form.pad_category") %> | ||
| </div> | ||
|
|
||
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1024 +/- ##
===========================================
+ Coverage 98.71% 98.72% +0.01%
===========================================
Files 71 71
Lines 1011 1019 +8
===========================================
+ Hits 998 1006 +8
Misses 13 13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1021
Code reviewers
Summary of issue
Add another block "What disposable products do you use?" "Які одноразові засоби ви використовуєте?" (pads OR tampons)
Instead of "Average Products Used Per Cycle" block, we need to make two other blocks
"Duration of menstruation" "Тривалість менструації" "Average of disposable products per day" "Кількість одноразових продуктів на день" and add info button for duration of menstruation field info when user hover over it, the text "mostly 3-5 days" "переважно 3-5 днів" should appear
Summary of change
Change Average Products used per cycle to "Duration of menstruation" and "Average of disposable products per day" and add select field "Disposable products in use" and change test to work with new fields
Result
Screencast.2025-02-19.19.23.29.mp4
CHECK LIST