-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHC calculator change fields #1024
base: develop
Are you sure you want to change the base?
Conversation
…e_products_per_day fields
|
||
<div class="pb-2 input_lable mt-6"> | ||
<%= label_tag "child_product_category", t(".form.pad_category") %> | ||
</div> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1024 +/- ##
===========================================
+ Coverage 98.71% 98.72% +0.01%
===========================================
Files 71 71
Lines 1011 1019 +8
===========================================
+ Hits 998 1006 +8
Misses 13 13 ☔ View full report in Codecov by Sentry. |
#1021
Code reviewers
Summary of issue
Add another block "What disposable products do you use?" "Які одноразові засоби ви використовуєте?" (pads OR tampons)
Instead of "Average Products Used Per Cycle" block, we need to make two other blocks
"Duration of menstruation" "Тривалість менструації" "Average of disposable products per day" "Кількість одноразових продуктів на день" and add info button for duration of menstruation field info when user hover over it, the text "mostly 3-5 days" "переважно 3-5 днів" should appear
Summary of change
Change Average Products used per cycle to "Duration of menstruation" and "Average of disposable products per day" and add select field "Disposable products in use" and change test to work with new fields
Result
Screencast.2025-02-19.19.23.29.mp4
CHECK LIST