transfer: callback: do not set sizes, do it in odb.add() #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2023
skshetry
changed the title
The transfer() api should not set sizes, as it's a responsibility of the caller. `transfer()` could be called with just one file to transfer, so a callback of size 1 does not make sense. This broke `checkout` as it checks out one by one. See iterative/dvc#6226
skshetry
force-pushed
the
fix-checkout-callback
branch
from
04883f4 to
3e1248f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 64.54% 64.54%
=======================================
Files 25 25
Lines 1932 1932
Branches 302 302
=======================================
Hits 1247 1247
Misses 630 630
Partials 55 55
☔ View full report in Codecov by Sentry. |
skshetry
commented
May 12, 2023
| @@ -172,6 +172,9 @@ def _on_error(_from_p: str, _to_p: str, exc: BaseException): | |||
|
|
|||
| from_paths, to_oids = zip(*to_add) | |||
| jobs: Optional[int] = kwargs.get("batch_size", kwargs.get("jobs")) | |||
|
|
|||
| callback.set_size(len(from_paths)) | |||
There was a problem hiding this comment.
Ideally, this should be handled by the caller of odb.add().
efiop
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transfer() api should not set sizes, as it's a responsibility of the caller.
transfer()could be called with just one file to transfer, so a callback of size 1 does not make sense.This broke
checkoutas it checks out one by one.Related iterative/dvc#6226.
Current dependencies on/for this PR: