fix checkout callback during add/commit

[skshetry]

Fix #6226.

Current dependencies on/for this PR:

• transfer: callback: do not set sizes, do it in odb.add() dvc-objects#208
  • checkout: set size dvc-data#355
    • fix checkout callback during add/commit #9445 👈🏼

TODO:

• Release dvc-objects
• Release dvc-data

[codecov]

Codecov Report

Patch coverage: 88.23% and project coverage change: -0.24 ⚠️

Comparison is base (2342099) 91.59% compared to head (a8716e2) 91.35%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9445      +/-   ##
==========================================
- Coverage   91.59%   91.35%   -0.24%     
==========================================
  Files         488      488              
  Lines       38090    38101      +11     
  Branches     5462     5464       +2     
==========================================
- Hits        34888    34807      -81     
- Misses       2637     2710      +73     
- Partials      565      584      +19     

Impacted Files	Coverage Δ
dvc/repo/worktree.py	9.72% <0.00%> (-0.05%)	⬇️
dvc/output.py	89.80% <100.00%> (+0.26%)	⬆️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[skshetry]

I don't like this that it passes an aggregated callback, but this seemed easier to do for now.

[skshetry]

@efiop, I am getting:

dvc/repo/worktree.py: note: In function "push_worktree":
dvc/repo/worktree.py:176:27: error: Unsupported operand types for + ("int" and
"Dict[str, List[Change]]")  [operator]
                    pushed += checkout(
                              ^
Found 1 error in 1 file (checked 283 source files

What is the equivalent to get total no of push now?

[efiop]

@skshetry Just sum up all the changes (it returns a dict of lists, just sum up length of all lists) for now. That worktree code will go away soon in #9424 anyway.

[skshetry]

There's unchanged too, right?

[efiop]

@skshetry No, this is index diff(checkout really) not hashfile diff, it has with_unchanged as an option that is not always turned on (at least right now).

[skshetry]

Thanks, updated.