index: check dep.hash_name for imports #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
fix-index-imp
branch
3 times, most recently
from
6e1320e
to
3be8d5c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10270 +/- ##
==========================================
- Coverage 90.42% 90.18% -0.24%
==========================================
Files 494 494
Lines 37821 37824 +3
Branches 5469 5470 +1
==========================================
- Hits 34201 34113 -88
- Misses 2986 3055 +69
- Partials 634 656 +22 ☔ View full report in Codecov by Sentry. |
efiop
force-pushed
the
fix-index-imp
branch
8 times, most recently
from
c49afb1
to
7010c85
Compare
efiop
force-pushed
the
fix-index-imp
branch
5 times, most recently
from
a5b3c26
to
b4d5dc0
Compare
efiop
commented
Feb 19, 2024
| @@ -106,6 +106,7 @@ def test_import_file(self, tmp_dir, dvc, remote_version_aware): | |||
| (remote_version_aware / "file").write_text("modified") | |||
| assert dvc.status().get("file.dvc") == [ | |||
| {"changed deps": {"remote://upstream/file": "update available"}}, | |||
| {"changed outs": {"file": "not in cache"}}, | |||
There was a problem hiding this comment.
dvc status doesn't yet work with fs-based cache and it happens to show up here, so this will have to wait a bit for #9333
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it might result in us trying to use etags with cache: