-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: use index fetch #9424
fetch: use index fetch #9424
Conversation
e26919f
to
b6fbe3e
Compare
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
Needed for iterative#9424
41c148c
to
cd096fb
Compare
1e8e4ae
to
63c0a3c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9424 +/- ##
==========================================
- Coverage 90.67% 90.54% -0.14%
==========================================
Files 470 470
Lines 35944 35886 -58
Branches 5180 5171 -9
==========================================
- Hits 32593 32493 -100
- Misses 2755 2800 +45
+ Partials 596 593 -3
☔ View full report in Codecov by Sentry. |
0b283e2
to
01095e1
Compare
@@ -182,7 +182,7 @@ def test_partial_checkout_and_update(M, tmp_dir, dvc, remote): | |||
|
|||
assert dvc.pull("dir/subdir") == M.dict( | |||
added=[join("dir", "")], | |||
fetched=1, | |||
fetched=3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an intentional change or an oversight? Previously, we could fetch subset of files, but after this PR, we fetch everything.
I was not aware about this change, which I just noticed when someone asked in https://discuss.dvc.org/t/why-dvc-pulls-full-dataset-instead-of-a-single-file/1897.
This breaks an important scenario for virtual directory, see https://dvc.org/doc/user-guide/data-management/modifying-large-datasets#modifying-remote-datasets.
Do we have no means to fetch a subset, @efiop?
Part of #9333
Notable improvements: